Change default domain in sdks from e2b.dev to e2b.app#635
Merged
Conversation
sitole
added
sdk
sitole
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
🦋 Changeset detectedLatest commit: 508b2f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mishushakov
approved these changes
Mar 24, 2025
Member
mishushakov
left a comment
mishushakov
left a comment
There was a problem hiding this comment.
I have approved the code changes, but also make sure to check if there's anything needed to be changed in the documentation and CLI.
jakubno
approved these changes
Mar 24, 2025
Member
|
There's no public url in CLI and in docs we only state how to get the url. There's nothing about how it should look like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.